-
Notifications
You must be signed in to change notification settings - Fork 143
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
npm ci
fails when installing via Deploy to Heroku button
#316
Comments
I believe the issues is exactly as the error message states: package-lock.json is out of sync with package.json. Steps to fix: rm package-lock.json, and then recreate the file using the following command npm i --package-lock-only (see reference here: https://www.codegrepper.com/code-examples/javascript/what+is+package-lock.json) |
Upon further investigation AND attempting to get a fix in place, I think this isn't actually package-lock issue. I suspect what's happening is related to a security incident. For more info see here: https://status.heroku.com/incidents/2413 |
Thank you for looking into this @lenay12 ... I finally get around to setting this up and .... blocked by salesforce. Please let me know if you come up with a solve. |
@lsmolic My solution for this had been to deploy it with the Google App Engine. I found the task trickier than it looks because the instructions available here were not comprehensive. I'm currently working on the demo of the site and haven't set it up for real. I plan to write something up when I go through it the second time, which may be a while. If you end up trying to do it yourself feel free to @ me from the Library Google Group. It did work eventually, but I had to make adjustments to the package.json, change the format of the .env file from what's recommended in the instructions and add google data store to house the read history the app uses. |
Was a fix ever found for this? I'm still getting the |
@drewx0r did you look at the link I provided above for the status of heroku? The issue isn't with this application it's with heroku, so the fix is to deploy the app using other means (listed in the readme). |
Got it. I wasn’t clear from the Heroku status page whether or not they’d resolved things partially or fully. Thanks for clarifying! |
Oh, you're right there's a fresh update from 4 days ago, it does look like it should have been resolved. Either way, my solution was to deploy using google cloud platform. you get a little more control over what you're doing, because troubleshooting someone else's deploy button is pretty tough :) |
I just tried to deploy via Heroku and it failed with the same error. Pasted below. -----> Building on the Heroku-22 stack -----> Creating runtime environment
-----> Installing binaries
-----> Installing dependencies
-----> Build failed
! Push rejected, failed to compile Node.js app. |
I solved this problem by deploying on Google Cloud and updating the files for the node.js version from 10 to 16. package.json: "engines": { and in app.yaml runtime: nodejs16 |
Context (Environment)
Heroku (Deploy to Heroku button)
Expected Behavior
npm ci
succeeds when deploying to HerokuActual Behavior
npm ci
fails when deploying to Heroku, due to a discrepancy between the package.json and package-lock.jsonTo Reproduce
Click the Deploy to Heroku button and enter all required environment variables
Possible Solution
Running
npm install
and pushing an updatedpackage-lock.json
The text was updated successfully, but these errors were encountered: