Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Filter events are triggered when filters are set and a new query is run #126

Open
wrigleyDan opened this issue Nov 25, 2024 · 0 comments
Open

Comments

@wrigleyDan
Copy link

Filter event tracking has a bug in Chorus.
In case a filter is set and a (new) query is entered, not only the query event is fired but also the brand filter event - although nothing has changed with the set of filters.

Steps to reproduce:

  1. Go to http://chorus-opensearch-edition.dev.o19s.com:3000/
  2. Select a filter, e.g. Philips as a brand filter
  3. Open OS Dashboards in a new tab: http://chorus-opensearch-edition.dev.o19s.com:5601
  4. Go to Dev Tools and execute the following query:
GET ubi_events/_search
{
  "query": {
    "match_all": {
      
    }
  }, "sort": [
    {
      "timestamp": {
        "order": "desc"
      }
    }
  ],
  "track_total_hits": true
}

You should see the latest event, namely the clicked brand filter.

  1. Go to the Chrous UI tab and enter a query, e.g. coffee
  2. Switch back to Dev Tools and observe multiple brand filter events although no brands were selected or deselcted.

Apparently, every query triggers a filter event if a filter already is selected.

It's also worth thinking about resetting the filters if a completely new query is entered vs. keeping the filters if the query is changed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant