core: update GWT to the newer version #992
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I will prepare PR with new dependencies into build-dependencies project a bit lately. |
Done, this is PR with new versions: oVirt/ovirt-engine-build-dependencies#38 |
dupondje
requested changes
Feb 7, 2025
| @@ -59,19 +59,6 @@ | |||
|
|
|||
| <build> | |||
| <plugins> | |||
|
|
|||
There was a problem hiding this comment.
Can we eventually put those changes in another commit?
There was a problem hiding this comment.
I think, yes.
I will leave here only version update, and then will create another PR with compile aligning on single java version.
There was a problem hiding this comment.
Done, but i need some time to check locally (builded successfully, but i need to install and check it by hands).
In new releases there are small fixes and possibility to build it with newer versions of java (up to 21). Signed-off-by: Stanislav Melnichuk <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In new releases there are small fixes and possibility to build it with newer versions of java (up to 21).
With GWT update I aligned maven configuration to build all modules with java-11.
It builded successfully on my machine.
I prepared small setup for testing (one host and one nfs storage domain).
And looked by hands on two browsers (firefox and chrome).
All things looks good for me.
Are you the owner of the code you are sending in, or do you have permission of the owner?
[y/n] y