-
-
Notifications
You must be signed in to change notification settings - Fork 517
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Wrong text in Circle when animated
is true
#67
Comments
I'm having the same issue. Is there a solution coming for this? Thanks. |
Hi there, I had the same issue. After some digging and experimenting, I got it to work by changing
in line 187 at Circle.js (node_modules\react-native-progress\Circle.js) to
Hope it helps. |
Same issue :( |
Is this issue solved? Still facing it... |
This issue is still not fixed, and it is very simple to fix... @phantom1299 has found the solution to the problem about 4 months ago and it is still not fix. |
Still facing this issue. The PR is pending, any news about this ? |
@Clafouti You need to modify it yourself, the author does not seem to code on this anymore. You could always fork it and make it better :) |
@LolnationCH I'm unable to reproduce this bug, can you post a minimal example code to reproduce? |
I did not test this, but it's an adaptation of my code link that I had to do the modification, otherwise it wouldn't work. Using : "react-native-progress": "^3.4.0" (package.json) |
@LolnationCH The problem with your code is that you are passing a string, not a number. If you replace it with |
Still happens when its a number, this was just a example, not what im actually doing. I call a function that sets exp to a float. |
It's really hard for me to fix if I can't reproduce, the code you just posted works fine if you fix the string bug. Could you set up an example project that demonstrates this? |
The issue still occurs, @oblador with string or float. |
@oblador minimum code is: import * as Progress from 'react-native-progress';
class SomethingNew extends PureComponent {
render() {
return (
<Progress.Circle
progress={0.67}
showsText={true}
/>
);
}
} Will be shown zero. |
same here! |
The PR #117 solved this issue to me |
Hello,
I have an issue where the text inside the circle is always at 0 if I don't set
animated={false}
. After looking at the code, it seems like this code is responsible :It's never entering the listener (I put some logs), so the
progressValue
is always 0.Thanks.
The text was updated successfully, but these errors were encountered: