Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

unsatisfiable classes when merged into vertebrate.owl #36

Open
RLWOHIO opened this issue Dec 18, 2019 · 13 comments
Open

unsatisfiable classes when merged into vertebrate.owl #36

RLWOHIO opened this issue Dec 18, 2019 · 13 comments
Assignees
Labels
bug Something isn't working

Comments

@RLWOHIO
Copy link

RLWOHIO commented Dec 18, 2019

The latest release (2019-11-12) is a big improvement over the previous version. When standing alone, all classes are satisfiable. After being incorporated into vertebrate.owl though, some of them became unsatisfied, as listed below:
ZFA_0000435
ZP_0000412
ZP_0002062
ZP_0002510
ZP_0002511
ZP_0002557
ZP_0003019
ZP_0003144
ZP_0003145
ZP_0003428
ZP_0004008
ZP_0004283
ZP_0004284
ZP_0004299
ZP_0005361
ZP_0005362
ZP_0005531
ZP_0005928
ZP_0006699
ZP_0006700
ZP_0006899
ZP_0006921
ZP_0006922
ZP_0008170
ZP_0008184
ZP_0008185
ZP_0008312
ZP_0008768
ZP_0009148
ZP_0010431
ZP_0010686
ZP_0010687
ZP_0010688
ZP_0011448
ZP_0011473
ZP_0011681
ZP_0011709
ZP_0011716
ZP_0011745
ZP_0011889
ZP_0012376
ZP_0012463
ZP_0012500
ZP_0013387
ZP_0014696
ZP_0014741
ZP_0014762
ZP_0014898
ZP_0015602
ZP_0016403
ZP_0016404
ZP_0016405
ZP_0016733
ZP_0016944
ZP_0016945
ZP_0016946
ZP_0017766
ZP_0018215
ZP_0018216
ZP_0018220
ZP_0018289
ZP_0018331
ZP_0019846
ZP_0019851
ZP_0019852
ZP_0019853
ZP_0019854
ZP_0020515
ZP_0020776
ZP_0020778
ZP_0021475
ZP_0021924
ZP_0022946
ZP_0100778
ZP_0100779
ZP_0100967
ZP_0102325
ZP_0102981
ZP_0102982
ZP_0103341
ZP_0103347
ZP_0103558
ZP_0103989
ZP_0106021
ZP_0107100
ZP_0107101
ZP_0108328

@matentzn
Copy link
Contributor

matentzn commented Jan 6, 2020

Thanks! Some of the unsatisfiablities may only be solved much later in the year! Feel free to drop me an email so I can tell you about the general trajectory of uPheno and ZP -> we are working hard on pushing for a fresh, conflict free Unified Phenotype ontology by the end of the month, and I would love to get your input/requirements if you have any! :) vertebrate.owl will hopefully be deprecated before the summer.

@RLWOHIO
Copy link
Author

RLWOHIO commented Jan 8, 2020 via email

@matentzn
Copy link
Contributor

matentzn commented Jan 9, 2020

Can you describe a bit what you are using vertebrate.owl for that you cant get from simply using ZP? Which table to you use for the gene:phenotype annotations?

@RLWOHIO
Copy link
Author

RLWOHIO commented Jan 13, 2020 via email

@matentzn
Copy link
Contributor

matentzn commented Jan 13, 2020

So basically you are looking for a phenotype ontology that integrates all vertebrate phenotypes (and their anatomy, gene functions etc)? How exactly do you use vertrebrate.owl if you dont mind me asking? In a software tool? Or just to retrieve stuff using Protege?

EDIT: This is not official yet, but you can probably check

For the data you need now. Note, and this is very important, that these tables are under development and only work for abnormal phenotypes. There are some wrong associations in there between abnormal ZP classes and NORMAL phenotypes.

@RLWOHIO
Copy link
Author

RLWOHIO commented Jan 16, 2020 via email

@matentzn
Copy link
Contributor

matentzn commented Feb 6, 2020

Can you describe your project in a bit more detail? Is your code on GitHub? What do you need from vertebrate.owl that you cant get from zp.owl all by itself?

@matentzn matentzn self-assigned this Feb 6, 2020
@matentzn matentzn added the bug Something isn't working label Feb 6, 2020
@RLWOHIO
Copy link
Author

RLWOHIO commented Mar 3, 2020 via email

@matentzn
Copy link
Contributor

matentzn commented Mar 4, 2020

We are developing a new version of the Unified Phenotype Ontology - this will eventually replace vertebrate.owl and the rest of upheno1; I would be interested in your feedback and see whether it covers your use cases. Its not published yet, but a test version is available here. Please let me know what you think and what is missing from in there (or too much) to cover your case.

@RLWOHIO
Copy link
Author

RLWOHIO commented Mar 4, 2020 via email

@RLWOHIO
Copy link
Author

RLWOHIO commented Mar 12, 2020

I have done some testing.  On its own, upheno_all_with_relations.owl (03/04/2020), is fine.  Once merged with my annotations and relevant imports by OntoFox, there was a total 35 unsatisfiable classes, all from ZP.  This is a huge improvement over vertebrate.owl dated Dec 2019 which had a total of 455 unsatisfiable classes including 340 ZPs. Please see the attached for details.  Hope this helps.
upheno_all_with_relations.owl.PLUS.mine2.owl.unsatisfiableZPs.pptx

@matentzn
Copy link
Contributor

Ah very cool. So it seems that all the phenotypes that are unsatisfiable are so because of ZFA, which in turn interacts badly with UBERON. Can you delete the axiom:

image

And check whether that is the problem? If so, I will talk to RO and UBERON and we will decide on how to fix it.

@RLWOHIO
Copy link
Author

RLWOHIO commented Mar 12, 2020 via email

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants