You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
When obot server is terminated with SIGINT (kill -2 <obot-server-pid>), it's child daemon tool processes are never terminated.
This isn't great. For example, it effectively prevents developers from stopping obot server Goland/delve debug sessions without killing the daemon tool processes directly.
Solution
Ensure that obot server properly propagates termination signals (like SIGINT) to the daemon tool processes it starts before exiting.
Fix Verification Gotchas
Running Ctrl-C from a common shell -- like bash and zsh -- sends SIGINT to the entire foreground process group, which includes the tool daemons started by obot server. This bypasses the graceful shutdown logic in Obot/GPTScript and means that it can't be used to effectively verify a fix.
Instead, any fix should be verified by executing kill -2 <obot-server-pid>, which will send SIGINT to only the parent obot server process.
The text was updated successfully, but these errors were encountered:
Setting this to medium because this has no immediate impact on Obot's functional features; i.e. it's pretty much only an issue during development (debugging).
Problem
When
obot server
is terminated withSIGINT
(kill -2 <obot-server-pid>
), it's child daemon tool processes are never terminated.This isn't great. For example, it effectively prevents developers from stopping
obot server
Goland/delve debug sessions without killing the daemon tool processes directly.Solution
Ensure that
obot server
properly propagates termination signals (likeSIGINT
) to the daemon tool processes it starts before exiting.Fix Verification Gotchas
Running
Ctrl-C
from a common shell -- likebash
andzsh
-- sendsSIGINT
to the entire foreground process group, which includes the tool daemons started byobot server
. This bypasses the graceful shutdown logic in Obot/GPTScript and means that it can't be used to effectively verify a fix.Instead, any fix should be verified by executing
kill -2 <obot-server-pid>
, which will sendSIGINT
to only the parentobot server
process.The text was updated successfully, but these errors were encountered: