ml-matrix Matrix constructor fails

[kletts]

I'm trying to use the matrix operations library from ml-matrix in an observable framework notebook for which the new Matrix constructor is returning the following error:

TypeError: Cannot read properties of null (reading 'isAnyArray')

The following code reproduces the error. The first two examples work, showing the import of the library was successful. The third example fails. Testing in node.js and in an online observable notebook the third example is working.

import { Matrix } from "npm:ml-matrix";
const mm1 = Matrix.ones(5, 5);
display(mm1);
const mm2 = new Matrix(2,2); 
display(mm2);
const mm3 = new Matrix([
  [1, 1],
  [2, 2],
]);
display(mm3);

ml-matrix does have a dependency on is-any-array

Any help would be appreciated.

Christian

[mbostock]

You can fix this by changing how you import ml-matrix like so:

import {Matrix} from "npm:ml-matrix/src/index.js/+esm";

The problem is that the default entry point for ml-matrix is matrix.mjs, which imports matrix.js, which is CommonJS generated by rollup. Unfortunately converting ES modules to CommonJS and back again loses information. If you look at the generated matrix.js, it imports is-any-array like this:

var isAnyArray = require('is-any-array');

and then references isAnyArray.isAnyArray. So when jsDelivr tries to convert this CommonJS back to an ES module, you get:

import t from"/npm/[email protected]/+esm";

and t.isAnyArray. But here t is the default export, not a namespace, so you get the error. The correct import of is-any-array is seen if you tell jsDelivr to produce the ES module bundle from the ES module source, ignoring ml-matrix’s CommonJS bundle.

import{isAnyArray as t}from"/npm/[email protected]/+esm";

Anyway, I’m sure this is all just annoying noise to you as the user of ml-matrix. But the real answer is that ml-matrix needs to fix its package.json so that it’s distributing valid ES modules, rather than an ES module that imports CommonJS.

[kletts]

Oh excellent thank you

[Fil]

to celebrate this I ported the pt utility to Framework:
https://observablehq.observablehq.cloud/pangea/varia/pt