Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add plugin: Sentinel #4984

Merged
merged 1 commit into from
Jan 24, 2025
Merged

Add plugin: Sentinel #4984

merged 1 commit into from
Jan 24, 2025

Conversation

gsarig
Copy link
Contributor

@gsarig gsarig commented Dec 27, 2024

Sentinel is a plugin for Obsidian that allows you to update properties or run commands based on document visibility changes.

I am submitting a new Community Plugin

Repo URL

Link to my plugin: https://github.com/gsarig/obsidian-sentinel

Release Checklist

  • I have tested the plugin on
    • Windows
    • macOS
    • Linux
    • Android (if applicable)
    • iOS (if applicable)
  • My GitHub release contains all required files (as individual files, not just in the source.zip / source.tar.gz)
    • main.js
    • manifest.json
    • styles.css (optional)
  • GitHub release name matches the exact version number specified in my manifest.json (Note: Use the exact version number, don't include a prefix v)
  • The id in my manifest.json matches the id in the community-plugins.json file.
  • My README.md describes the plugin's purpose and provides clear usage instructions.
  • I have read the developer policies at https://docs.obsidian.md/Developer+policies, and have assessed my plugins's adherence to these policies.
  • I have read the tips in https://docs.obsidian.md/Plugins/Releasing/Plugin+guidelines and have self-reviewed my plugin to avoid these common pitfalls.
  • I have added a license in the LICENSE file.
  • My project respects and is compatible with the original license of any code from other plugins that I'm using.
    I have given proper attribution to these other projects in my README.md.

@ObsidianReviewBot
Copy link
Collaborator

The automated review has not found any issues with your code, ready for manual review.

@joethei
Copy link
Collaborator

joethei commented Jan 13, 2025

Copyright (c) 2023 xRyul
Update this

import moment from "moment";
Import this through the Obsidian package instead.

const suggestionContainer = actionContainer.createDiv('suggestion-container');
Implement a AbstractInputSuggest for this instead.

containerEl.createEl('p', {
This should not be here, if you want to include it on your settings tab then put it in the footer.
While it's not explicitly mentioned in our guidelines, it does look out of place at the top compared to app settings.
https://docs.obsidian.md/Plugins/Releasing/Plugin+guidelines#UI+text

containerEl.createEl('h3', {text: 'Actions'});
Use sentence case in UI

.setButtonText('Add Action')
Use sentence case in UI

export async function propertyUpdater(
Use the processFrontMatter function instead of manually modifying the YAML.

@joethei joethei self-assigned this Jan 13, 2025
@joethei joethei added Changes requested Minor changes requested PR can be merged after some final changes have been requested and removed Ready for review labels Jan 13, 2025
@ObsidianReviewBot ObsidianReviewBot added Ready for review Changes made and removed Changes requested Minor changes requested PR can be merged after some final changes have been requested labels Jan 18, 2025
Sentinel is a plugin for Obsidian that allows you to update properties or run commands based on document visibility changes.
@joethei joethei merged commit 62a52ba into obsidianmd:master Jan 24, 2025
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants