Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add plugin: Video Tracks #5130

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Add plugin: Video Tracks #5130

wants to merge 2 commits into from

Conversation

DDnim
Copy link

@DDnim DDnim commented Jan 12, 2025

I am submitting a new Community Plugin

Repo URL

Link to my plugin:

Release Checklist

  • I have tested the plugin on
    • Windows
    • macOS
    • Linux
    • Android (if applicable)
    • iOS (if applicable)
  • My GitHub release contains all required files (as individual files, not just in the source.zip / source.tar.gz)
    • main.js
    • manifest.json
    • styles.css (optional)
  • GitHub release name matches the exact version number specified in my manifest.json (Note: Use the exact version number, don't include a prefix v)
  • The id in my manifest.json matches the id in the community-plugins.json file.
  • My README.md describes the plugin's purpose and provides clear usage instructions.
  • I have read the developer policies at https://docs.obsidian.md/Developer+policies, and have assessed my plugins's adherence to these policies.
  • I have read the tips in https://docs.obsidian.md/Plugins/Releasing/Plugin+guidelines and have self-reviewed my plugin to avoid these common pitfalls.
  • I have added a license in the LICENSE file.
  • My project respects and is compatible with the original license of any code from other plugins that I'm using.
    I have given proper attribution to these other projects in my README.md.

Copy link

Hello!

I found the following issues in your plugin submission

Errors:

❌ Plugin name mismatch, the name in this PR (Video tracks) is not the same as the one in your repo (Video Tracks). If you just changed your plugin name, remember to change it in the manifest.json in your repo and your latest GitHub release.


This check was done automatically. Do NOT open a new PR for re-validation. Instead, to trigger this check again, make a change to your PR and wait a few minutes, or close and re-open it.

@github-actions github-actions bot changed the title Add plugin: Video tracks Add plugin: Video Tracks Jan 12, 2025
@ObsidianReviewBot
Copy link
Collaborator

Thank you for your submission, an automated scan of your plugin code's revealed the following issues:


Optional

[1]:Casting to any should be avoided as much as possible.

[1]:Obsidian provides the requestUrl method, it will make sure that network requests work on every plattform.


Do NOT open a new PR for re-validation.

@ObsidianReviewBot ObsidianReviewBot removed their assignment Jan 13, 2025
@Zachatoo
Copy link
Collaborator

# Obsidian Video Transcription Plugin, # Obsidian ビデオ文字起こしプラグイン, # Obsidian 视频转录插件
Naming something "Obsidian xyz" is reserved for first party products we create, please change this header.

video.addEventListener('timeupdate', this.videoTimeUpdateHandler);
Please use registerDomEvent to ensure these event listeners are removed when your plugin is unloaded.

this.addRibbonIcon('audio-file', 'Convert Video to MP3 and Transcribe', async () => {, .setName('FFmpeg Path'), .setName('Groq API Key'), containerEl.createEl('h3', {text: 'Output Formats'});, .setName('Line Break Style'), .addOption('single', 'Single Line Break'), .setName('Plain Mode'), .setName('Basic Mode'), .setName('Advance Mode')
Use sentence case in UI

const response = await fetch('https://api.groq.com/openai/v1/audio/transcriptions', {
Use the requestUrl function from the Obsidian API instead, it will handle some things like CORS automatically.

containerEl.createEl('h3', {text: 'Output Formats'});
For section headings in settings use:

new Setting(containerEl).setName('name here').setHeading();

await this.app.vault.adapter.exists(outputPath.replace(vaultPath + '/', ''));
This returns true or false depending on if the file exists or not, but you aren't validating if it's true or not before proceeding. You should check the result of this function if you're wanting to validate that the file was created by ffmpeg.

this.setupVideoEventListeners();
Wrap this in onLayoutReady to ensure workspace is loaded before adding event listeners.

@Zachatoo Zachatoo self-assigned this Jan 25, 2025
@Zachatoo Zachatoo added Changes requested Additional review required PR needs to be reviewed by another person, after the currently requested changes have been made and removed Ready for review labels Jan 25, 2025
Copy link

Hi there, as this PR has not seen any activity in the last 30 days, it will be closed in 15 days unless there are any updates.

@github-actions github-actions bot added the stale label Feb 24, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Additional review required PR needs to be reviewed by another person, after the currently requested changes have been made Changes requested plugin stale
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants