Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add plugin: BlueprintUE Embed #5132

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Conversation

litruv
Copy link

@litruv litruv commented Jan 13, 2025

I am submitting a new Community Plugin

Repo URL

Link to my plugin: https://github.com/litruv/Obsidian-BlueprintUE

Release Checklist

  • I have tested the plugin on
    • Windows
    • macOS
    • Linux
    • Android (if applicable)
    • iOS (if applicable)
  • My GitHub release contains all required files (as individual files, not just in the source.zip / source.tar.gz)
    • main.js
    • manifest.json
    • styles.css (optional)
  • GitHub release name matches the exact version number specified in my manifest.json (Note: Use the exact version number, don't include a prefix v)
  • The id in my manifest.json matches the id in the community-plugins.json file.
  • My README.md describes the plugin's purpose and provides clear usage instructions.
  • I have read the developer policies at https://docs.obsidian.md/Developer+policies, and have assessed my plugins's adherence to these policies.
  • I have read the tips in https://docs.obsidian.md/Plugins/Releasing/Plugin+guidelines and have self-reviewed my plugin to avoid these common pitfalls.
  • I have added a license in the LICENSE file.
  • My project respects and is compatible with the original license of any code from other plugins that I'm using.
    I have given proper attribution to these other projects in my README.md.

Copy link

Hello!

I found the following issues in your plugin submission

Errors:

❌ Please don't use the word obsidian in the plugin ID. The ID is used for your plugin's folder so keeping it short and simple avoids clutter and helps with sorting.
❌ The plugin ID is not valid. Only alphanumeric lowercase characters and dashes are allowed.
❌ Please don't include Obsidian in the plugin description
❌ Your latest Release is missing the main.js file.
❌ Your latest Release is missing the manifest.json file.


This check was done automatically. Do NOT open a new PR for re-validation. Instead, to trigger this check again, make a change to your PR and wait a few minutes, or close and re-open it.

Copy link

Hello!

I found the following issues in your plugin submission

Errors:

❌ Plugin ID mismatch, the ID in this PR (embed-blueprintue) is not the same as the one in your repo (embedblueprintue). If you just changed your plugin ID, remember to change it in the manifest.json in your repo and your latest GitHub release.
❌ Your latest Release is missing the main.js file.
❌ Your latest Release is missing the manifest.json file.


This check was done automatically. Do NOT open a new PR for re-validation. Instead, to trigger this check again, make a change to your PR and wait a few minutes, or close and re-open it.

Copy link
Author

@litruv litruv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changed up

@litruv litruv marked this pull request as draft January 13, 2025 06:46
@litruv litruv marked this pull request as ready for review January 13, 2025 06:46
@litruv litruv closed this Jan 13, 2025
@litruv litruv reopened this Jan 13, 2025
@litruv
Copy link
Author

litruv commented Jan 13, 2025

Phew, finally, not done PR too often, sorry lads

@ObsidianReviewBot
Copy link
Collaborator

Thank you for your submission, an automated scan of your plugin code's revealed the following issues:

Required

[1]:Please remove the main.js file from the repo and add it to your .gitignore. Compiled release files shouldn't get mixed with source code in your commits and should go to the releases files instead.


Do NOT open a new PR for re-validation.
Once you have pushed all of the required changes to your repo, the bot will update the labels on this PR within 6 hours.
If you think some of the required changes are incorrect, please comment with /skip and the reason why you think the results are incorrect.

@ObsidianReviewBot ObsidianReviewBot added Changes requested Additional review required PR needs to be reviewed by another person, after the currently requested changes have been made Ready for review and removed Ready for review Changes requested Additional review required PR needs to be reviewed by another person, after the currently requested changes have been made labels Jan 14, 2025
@ObsidianReviewBot ObsidianReviewBot removed their assignment Jan 14, 2025
@ObsidianReviewBot
Copy link
Collaborator

Changes requested by bot have been made, ready for additional review by human.

@joethei
Copy link
Collaborator

joethei commented Jan 27, 2025

A screenshot of the embedded blueprint in the README would be good.

Your code looks generated, did you write the plugin in JavaScript or TypeScript?
If you have manually written the plugin, please remove the unnecessary code (the first ~20 lines)

Please also add some information in your README that makes it clear that your plugin only works in reading mode.

MyPlugin
Rename this.

document.createElement("iframe");
This will break when using pop out windows, use el.createEl

@joethei joethei self-assigned this Jan 27, 2025
@joethei joethei added Changes requested Minor changes requested PR can be merged after some final changes have been requested and removed Ready for review labels Jan 27, 2025
Copy link

Hi there, as this PR has not seen any activity in the last 30 days, it will be closed in 15 days unless there are any updates.

@github-actions github-actions bot added the stale label Feb 27, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Changes requested Minor changes requested PR can be merged after some final changes have been requested plugin stale
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants