Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add plugin: Canva Embed #5125

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Conversation

Jenna225
Copy link

@Jenna225 Jenna225 commented Jan 12, 2025

I am submitting a new Community Plugin

Repo URL

Link to my plugin:https://github.com/Jenna225/obsidian-canva-plugin.git

Release Checklist

  • I have tested the plugin on
    • Windows
    • macOS
    • Linux
    • Android (if applicable)
    • iOS (if applicable)
  • My GitHub release contains all required files (as individual files, not just in the source.zip / source.tar.gz)
    • main.js
    • manifest.json
    • styles.css (optional)
  • GitHub release name matches the exact version number specified in my manifest.json (Note: Use the exact version number, don't include a prefix v)
  • The id in my manifest.json matches the id in the community-plugins.json file.
  • My README.md describes the plugin's purpose and provides clear usage instructions.
  • I have read the developer policies at https://docs.obsidian.md/Developer+policies, and have assessed my plugins's adherence to these policies.
  • I have read the tips in https://docs.obsidian.md/Plugins/Releasing/Plugin+guidelines and have self-reviewed my plugin to avoid these common pitfalls.
  • I have added a license in the LICENSE file.
  • My project respects and is compatible with the original license of any code from other plugins that I'm using.
    I have given proper attribution to these other projects in my README.md.

Copy link

Hello!

I found the following issues in your plugin submission

Errors:

❌ Plugin ID mismatch, the ID in this PR (canva-embed) is not the same as the one in your repo (canva-obsidian). If you just changed your plugin ID, remember to change it in the manifest.json in your repo and your latest GitHub release.
❌ Your latest Release is missing the main.js file.


Warnings:

⚠️ Your repository does not have issues enabled. Users will not be able to report bugs and request features.


This check was done automatically. Do NOT open a new PR for re-validation. Instead, to trigger this check again, make a change to your PR and wait a few minutes, or close and re-open it.

@Jenna225
Copy link
Author

i update the repo id and add the main.js file

Copy link

Hello!

I found the following issues in your plugin submission

Warnings:

⚠️ Your repository does not have issues enabled. Users will not be able to report bugs and request features.


This check was done automatically. Do NOT open a new PR for re-validation. Instead, to trigger this check again, make a change to your PR and wait a few minutes, or close and re-open it.

@github-actions github-actions bot changed the title Add Canva Embed plugin Add plugin: Canva Embed Jan 12, 2025
@ObsidianReviewBot
Copy link
Collaborator

Thank you for your submission, an automated scan of your plugin code's revealed the following issues:

Required

[1][2][3][4][5][6]:You should avoid assigning styles via JavaScript or in HTML and instead move all these styles into CSS so that they are more easily adaptable by themes and snippets.


Do NOT open a new PR for re-validation.
Once you have pushed all of the required changes to your repo, the bot will update the labels on this PR within 6 hours.
If you think some of the required changes are incorrect, please comment with /skip and the reason why you think the results are incorrect.

@ObsidianReviewBot ObsidianReviewBot added Changes requested Additional review required PR needs to be reviewed by another person, after the currently requested changes have been made and removed Ready for review labels Jan 13, 2025
Copy link

Hi there, as this PR has not seen any activity in the last 30 days, it will be closed in 15 days unless there are any updates.

Copy link

Hello!

I found the following issues in your plugin submission

Warnings:

⚠️ Your repository does not have issues enabled. Users will not be able to report bugs and request features.


This check was done automatically. Do NOT open a new PR for re-validation. Instead, to trigger this check again, make a change to your PR and wait a few minutes, or close and re-open it.

1 similar comment
Copy link

Hello!

I found the following issues in your plugin submission

Warnings:

⚠️ Your repository does not have issues enabled. Users will not be able to report bugs and request features.


This check was done automatically. Do NOT open a new PR for re-validation. Instead, to trigger this check again, make a change to your PR and wait a few minutes, or close and re-open it.

@github-actions github-actions bot removed the stale label Feb 13, 2025
@Jenna225
Copy link
Author

I have now enabled the Issues feature for the repository, so users can report bugs and request features. Thank you.

@Jenna225 Jenna225 reopened this Feb 13, 2025
Copy link

Hello!

I found the following issues in your plugin submission

Warnings:

⚠️ Your repository does not have issues enabled. Users will not be able to report bugs and request features.


This check was done automatically. Do NOT open a new PR for re-validation. Instead, to trigger this check again, make a change to your PR and wait a few minutes, or close and re-open it.

1 similar comment
Copy link

Hello!

I found the following issues in your plugin submission

Warnings:

⚠️ Your repository does not have issues enabled. Users will not be able to report bugs and request features.


This check was done automatically. Do NOT open a new PR for re-validation. Instead, to trigger this check again, make a change to your PR and wait a few minutes, or close and re-open it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Additional review required PR needs to be reviewed by another person, after the currently requested changes have been made Changes requested plugin
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants