From 1ba5ae551e6b3be7136aaea73ea346f79c55deea Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Ulysse=20G=C3=A9rard?= Date: Fri, 13 Dec 2024 11:17:20 +0100 Subject: [PATCH] Fix regression in construct test --- src/ocaml/typing/typecore.ml | 2 ++ tests/test-dirs/construct/c-inline-record-issue1617.t | 7 +++++-- 2 files changed, 7 insertions(+), 2 deletions(-) diff --git a/src/ocaml/typing/typecore.ml b/src/ocaml/typing/typecore.ml index 234ac4cc3..e87f52633 100644 --- a/src/ocaml/typing/typecore.ml +++ b/src/ocaml/typing/typecore.ml @@ -5804,6 +5804,8 @@ and type_construct env ~sexp lid sarg ty_expected_explained = | None -> Rejected | Some _ -> begin match sargs with + | [{pexp_desc = Pexp_extension ({ txt; _ }, _)}] + when txt = Ast_helper.hole_txt -> Required | [{pexp_desc = Pexp_ident _ | Pexp_record (_, (Some {pexp_desc = Pexp_ident _}| None))}] -> diff --git a/tests/test-dirs/construct/c-inline-record-issue1617.t b/tests/test-dirs/construct/c-inline-record-issue1617.t index 7d5985a64..0519a361c 100644 --- a/tests/test-dirs/construct/c-inline-record-issue1617.t +++ b/tests/test-dirs/construct/c-inline-record-issue1617.t @@ -16,5 +16,8 @@ Construct also works with inline records $ $MERLIN single construct -position 7:15 \ - > -filename main.ml -filename main.ml