Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Avoid manual repetition of suffixes in a make script #244

Open
elfring opened this issue Jul 1, 2017 · 4 comments
Open

Avoid manual repetition of suffixes in a make script #244

elfring opened this issue Jul 1, 2017 · 4 comments

Comments

@elfring
Copy link

elfring commented Jul 1, 2017

A suffix like “cmo” is repeated several times for the definition of two variables. I suggest to avoid this.

  • The function “addsuffix” can perform the desired data transformation for you.
  • It can also be a bit more efficient to append suffixes at other places instead of replacing them, can't it?
@whitequark
Copy link
Member

Efficiency is really not a concern here. I'd be surprised if ocamlbuild spends even a hundred milliseconds in make itself.

@elfring
Copy link
Author

elfring commented Jul 1, 2017

Do you like a bit of code reduction more there?

@whitequark
Copy link
Member

Yeah, that's a perfectly sensible change.

@gasche
Copy link
Member

gasche commented Jul 1, 2017

@elfring would you like to send a pull request?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants