Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[new release] Five Ortac packages 0.4.0 #26691

Merged
merged 3 commits into from
Oct 11, 2024
Merged

Conversation

n-osborne
Copy link
Contributor

This release brings a number of new features and improvements:

  • New features:
    • #247: Generated tests cover now functions with multiple SUT arguments
    • #253: Generated tests cover now functions returning SUT values
    • #259: Generated tests can be run in a separated process with a timeout
  • Improvements:
    • #245: Fix the analysis of function signature to explicitly not support SUTs inside another type
    • #251: Fix the display of the runnable scenario for value returned by a function that could have raised an exception

@mseri
Copy link
Member

mseri commented Oct 8, 2024

Does
ortac-qcheck-stm.0.2.0 (failed: This expression has type ('a, STM.res) Either.t) require an upper bound on ortac 0.4.0?

Copy link
Contributor

@jmid jmid left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Indeed. A few of the with-test dependencies need to be version-constrained too, to avoid such cross-version combinations.

packages/ortac-core/ortac-core.0.4.0/opam Outdated Show resolved Hide resolved
packages/ortac-dune/ortac-dune.0.4.0/opam Outdated Show resolved Hide resolved
@n-osborne
Copy link
Contributor Author

n-osborne commented Oct 9, 2024

True. Thanks @jmid for the updates 😃

@jmid
Copy link
Contributor

jmid commented Oct 9, 2024

Yikes, this is still failing, e.g. with

ortac-core.0.4.0
  revdeps
    ortac-qcheck-stm.0.2.0 (failed: This expression has type ('a, STM.res) Either.t)

I think we need to separately constrain 0.2 from installing with 0.4.
In ortac-qcheck-stm/ortac-qcheck-stm.0.2.0/opam for example, I can see

depends: [
..
  "ortac-core" {>= "0.2.0"}
  "ortac-runtime" {with-test}
  "ortac-runtime-qcheck-stm" {with-test}
  "odoc" {with-doc}
]

which could benefit from = version constraints too!
This is probably best done in a separate PR though...

@n-osborne
Copy link
Contributor Author

n-osborne commented Oct 9, 2024

I was thinking the same and in the process of adding a commit to this PR with stricter dependencies constraints (next release of Gospel is also expected to bring breaking changes).
But I'm happy to put these changes in another PR.

@n-osborne
Copy link
Contributor Author

#26697 should improve the situation

@jmid
Copy link
Contributor

jmid commented Oct 10, 2024

#26697 and #26702 have now been merged. Can you push a rebased version? I'm keen to see if the fixes have solved the red lights... 😃

n-osborne and others added 3 commits October 10, 2024 14:18
This release brings a number of new features and improvements:

- New features:
  + [ocaml#247](ocaml-gospel/ortac#247): Generated tests cover now functions with multiple SUT arguments
  + [ocaml#253](ocaml-gospel/ortac#253): Generated tests cover now functions returning SUT values
  + [ocaml#259](ocaml-gospel/ortac#259): Generated tests can be run in a separated process with a timeout
- Improvements:
  + [ocaml#245](ocaml-gospel/ortac#245): Fix the analysis of function signature to explicitly not support SUTs inside
    another type
  + [ocaml#251](ocaml-gospel/ortac#251): Fix the display of the runnable scenario for value returned by a function
    that could have raised an exception
@jmid
Copy link
Contributor

jmid commented Oct 10, 2024

All green and good to go!

@mseri
Copy link
Member

mseri commented Oct 11, 2024

Thanks!

@mseri mseri merged commit 44a6012 into ocaml:master Oct 11, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants