Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

opam lock does not exit with an error code after displaying an error #5520

Open
lefessan opened this issue Apr 22, 2023 · 1 comment · May be fixed by #6341
Open

opam lock does not exit with an error code after displaying an error #5520

lefessan opened this issue Apr 22, 2023 · 1 comment · May be fixed by #6341
Labels
easy first issue KIND: BUG

Comments

@lefessan
Copy link
Contributor

When some dependencies are requested in the .opam file, but are not yet installed in the current switch, opam lock will display an error about missing dependencies, but will still exit normally at the end.

Because of this behavior, scripts are not able to correctly detect the error when calling opam lock.
@progressive-galib
Copy link

progressive-galib commented Dec 18, 2024 •
edited
Loading

https://github.com/ocaml/opam/blob/master/src/client/opamLockCommand.ml#L31-L32

the problem seems to be here, i am fixing it.

progressive-galib added a commit to progressive-galib/opam that referenced this issue Dec 19, 2024
@progressive-galib
fixed ocaml#5520
1e81a45
@progressive-galib progressive-galib linked a pull request Dec 19, 2024 that will close this issue
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
easy first issue KIND: BUG
Projects
None yet
Milestone
No milestone
4 participants
@lefessan @kit-ty-kate @rjbou @progressive-galib