Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

filter unsubscribe emails #1558

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

Conversation

Ndipbanyan
Copy link
Contributor

Issue Description

On the https://ocaml.org/community/ page, the recent email threads show all emails sent to the list, including unsubscribe emails.

Fixes #1513

Changes Made

I wrote a regex in the /rsshtml.ml file to filter out the unsubscribe emails from being displayed.

  • Please check if the PR fulfills these requirements
  • PR is descriptively titled and links the original issue above
  • Before/after screenshots (if this is a layout change)
  • Details of which platforms the change was tested on (if this is a browser-specific change)
  • Context for what motivated the change (if this is a change to some content)

@@ -589,7 +589,7 @@ let delete_author title =
(* Remove the "[Caml-list]" and possible "Re:". *)
let caml_list_re =
Str.regexp_case_fold "^\\(Re: *\\)*\\(\\[[a-zA-Z0-9-]+\\] *\\)*"

let unsubscribe_email_re= Str.regexp_case_fold ".*unsubscribe.*"
Copy link

@gs0510 gs0510 Apr 24, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you add a newline before and after unsubscribe_email_re? Thanks! :))

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I just did. :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Filter email list to not show unsubscribe emails.
2 participants