-
Notifications
You must be signed in to change notification settings - Fork 345
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Spring clean up: detect and delete dead scripts #1531
Comments
Hey @pitag-ha , I'm interested in working on this issue. Can I give it a try? |
@dldisha, sure, go ahead :) |
@pitag-ha, please review my code changes. |
Thanks for your work on this @dldisha :) What has been your approach to find out if a script is still having an impact on the site or not? |
Hi @dldisha. Are you still working on this issue? :) |
Hello @pitag-ha @patricoferris, I am interested to work on the issue. If anyone is still not working on this issue, can you please assign this to me? Thanks :) |
Hi @jyotibalodhi, we can't guarantee that we could help out with questions and review/merge a PR soon, but if no one else is working on this issue, feel free to work on it! :) @dldisha, @gurleennsidhuu, is anyone of you working on this? |
Hi. I have not yet started working on this as I was waiting for @dldisha's reply. If she's not working on this, I would like to start working. Thanks. :) |
No problem @pitag-ha !! I would love to work on some issues though. :) @gurleennsidhuu sure, you can go ahead, and if you face any issues, I would be happy to help. |
@gurleennsidhuu you might want to check out @dldisha's PR #1538 for some leads on the same issue :) |
There are a couple of scripts that seem to be dead code, e.g.
ocamlapplet.bash
andlink_blog_doc_ext.sh
. I propose that someone goes through all scripts in thescript/
folder and finds and deletes the ones that don't have an impact anymore.How
There are different ways to check if a script still has an impact (on the build). One option would be to build the page as is and save the result, then remove the script and build the page again, and then make a recursive diff on the two results.
Watch out
In the first run, you might wrongly detect scripts that are meant for development as dead code. Have a look if the scripts you detect are used for development.
The text was updated successfully, but these errors were encountered: