Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[FEAT]: No wait #39

Closed
1 task done
manuelmeurer opened this issue Sep 26, 2023 · 4 comments · Fixed by #40
Closed
1 task done

[FEAT]: No wait #39

manuelmeurer opened this issue Sep 26, 2023 · 4 comments · Fixed by #40
Labels
Status: Up for grabs Issues that are ready to be worked on by anyone Type: Feature New feature or request

Comments

@manuelmeurer
Copy link
Contributor

manuelmeurer commented Sep 26, 2023 •
edited
Loading

Describe the need

I would like to retry something a few times with no wait in between, and therefore pass wait: false or wait: 0 to the poll method.

Currently I get the error messages "Cannot wait backwards in time" or "undefined method `positive?' for false:FalseClass" when passing "0" or "false" as parameters, respectively.

SDK Version

No response

API Version

No response

Relevant log output

No response

Code of Conduct

  • I agree to follow this project's Code of Conduct
@manuelmeurer manuelmeurer added Status: Triage This is being looked at and prioritized Type: Feature New feature or request labels Sep 26, 2023
@github-actions
Copy link

👋 Hi! Thank you for this contribution! Just to let you know, our GitHub SDK team does a round of issue and PR reviews twice a week, every Monday and Friday! We have a process in place for prioritizing and responding to your input. Because you are a part of this community please feel free to comment, add to, or pick up any issues/PRs that are labled with Status: Up for grabs. You & others like you are the reason all of this works! So thank you & happy coding! 🚀

@manuelmeurer
Copy link
Contributor Author

Happy to implement this as a feature btw. 😄

@nickfloyd nickfloyd added Status: Up for grabs Issues that are ready to be worked on by anyone and removed Status: Triage This is being looked at and prioritized labels Sep 27, 2023
@nickfloyd
Copy link
Contributor

Hey @manuelmeurer I think that would be a solid addition!

Work up a PR for this and I'd be glad to look over it and hopefully get it in! Thanks for working to make octopoller and this community better ❤ !

@manuelmeurer
Copy link
Contributor Author

Nice! Would you allow false, 0 or both as params?

manuelmeurer added a commit to manuelmeurer/octopoller.rb that referenced this issue Sep 28, 2023
@manuelmeurer
allow passing 0, false or nil as the "wait" parameter to disable wait…
405ab87 
…ing, fixes octokit#39
@manuelmeurer manuelmeurer mentioned this issue Sep 28, 2023
Merged
4 tasks
manuelmeurer added a commit to manuelmeurer/octopoller.rb that referenced this issue Sep 28, 2023
@manuelmeurer
allow passing 0, false or nil as the "wait" parameter to disable wait…
770786a 
…ing, fixes octokit#39
manuelmeurer added a commit to manuelmeurer/octopoller.rb that referenced this issue Sep 28, 2023
@manuelmeurer
allow passing 0, false or nil as the "wait" parameter to disable wait…
6e6882c 
…ing, fixes octokit#39
manuelmeurer added a commit to manuelmeurer/octopoller.rb that referenced this issue Sep 29, 2023
@manuelmeurer
allow passing 0, false or nil as the "wait" parameter to disable wait…
44b3185 
…ing, fixes octokit#39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Status: Up for grabs Issues that are ready to be worked on by anyone Type: Feature New feature or request
Projects
🧰 Octokit Active
Archived in project
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[feat]: Allow wait to accept 0, false and nil to disable waiting. manuelmeurer/octopoller.rb
2 participants
@manuelmeurer @nickfloyd