Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Current dbal storage does not support extensions. #22

Open
wizhippo opened this issue Nov 29, 2019 · 3 comments
Open

Current dbal storage does not support extensions. #22

wizhippo opened this issue Nov 29, 2019 · 3 comments
Labels
enhancement New feature or request help wanted Extra attention is needed

Comments

@wizhippo
Copy link

Perhaps the serialization format for dbal should be changed to RFC-3966?

Discussion at misd-service-development#183

@odolbeau
Copy link
Owner

odolbeau commented Dec 6, 2019

Hi @wizhippo
I took a look at the discussion you mentioned & I think we should create another Doctrine Type (or find a way to configure the actual one) instead of changing the current Doctrine Type default behavior.
WDYT?

@wizhippo
Copy link
Author

wizhippo commented Dec 6, 2019

I would be fine either way. Lets make sure we document it so no one is surprised all their extensions are missing. I would prefer though that by default extensions are stored. I know this is a BC break but I believe it would the the default expected behavior to support extensions as the phonenumber type supports methods specifically for has/get/set for the extension.

@maxhelias maxhelias added enhancement New feature or request help wanted Extra attention is needed labels Nov 14, 2020
@Nek-
Copy link
Collaborator

Nek- commented Jan 20, 2021

Hello @wizhippo thanks for reaching out on the topic.

For this, to work I actually suggest creating an embeddable object. As a European, I have no idea what is a phone extension. But not supporting it in the standard format number comes from google.

The doctrine type we suggest cannot as it supports in any way the extension system. But is there any format supported by the library that actually does? Can you provide examples?

As I understand we should actually store the phone number in RFC3966 format instead of E164, is that correct? In this case, the solution looks simple: we need to change the phone number type by making a new one.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request help wanted Extra attention is needed
Projects
None yet
Development

No branches or pull requests

4 participants