Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update air conditioning example #801

Open
wants to merge 4 commits into
base: master
Choose a base branch
from

Conversation

Thuener
Copy link
Collaborator

@Thuener Thuener commented Nov 5, 2024

Closes #798

  • Add reference to Birge and Louveaux
  • Show the optimal values and test them

Copy link

codecov bot commented Nov 5, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 93.54%. Comparing base (b4c0a25) to head (27be7d3).

Additional details and impacted files
@@           Coverage Diff           @@
##           master     #801   +/-   ##
=======================================
  Coverage   93.54%   93.54%           
=======================================
  Files          26       26           
  Lines        3519     3519           
=======================================
  Hits         3292     3292           
  Misses        227      227           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Thuener
Copy link
Collaborator Author

Thuener commented Nov 5, 2024

@odow how do you do format checks locally?

@odow
Copy link
Owner

odow commented Nov 6, 2024

using JuliaFormatter
format("docs"; verbose = true)
format("benchmarks"; verbose = true)
format("src"; verbose = true)
format("test"; verbose = true)

@odow
Copy link
Owner

odow commented Nov 6, 2024

But I assumed @bernardokp wanted the examples fleshed out into proper literate tutorials (like the JuMP ones), not just some extra prints added.

@bernardokp
Copy link

Yeah, that would be ideal.

@Thuener
Copy link
Collaborator Author

Thuener commented Nov 6, 2024

@bernardokp
Copy link

I mean, that would be a luxury!!!

@Thuener
Copy link
Collaborator Author

Thuener commented Nov 7, 2024

That will take some time. I taught it was just an small change, I don't have this time to spare right now.

@odow
Copy link
Owner

odow commented Nov 7, 2024

That will take some time

That's why I haven't done it 😄

@Thuener
Copy link
Collaborator Author

Thuener commented Nov 8, 2024

I'm not crazy, I asked before creating the PR 😅
image

@Thuener
Copy link
Collaborator Author

Thuener commented Nov 8, 2024

If the goal is to create a tutorial, I can't promise anything now. @bernardokp you can help create the text? At least give me an initial version, I will extend it and create the code for it.

@bernardokp
Copy link

I certainly can help. As a matter of fact, it would be nice if we could create sort of a procedure to do it because I will probably create more examples in the very near future.

@bernardokp
Copy link

Is that what you want, @Thuener ?

The air conditioning example first appeared in the book Introduction to Stochastic Programming, by Birge and Louveaux, 1997, Springer-Verlag, New York. It is on page 237, example 1. For a rescaled problem, they report an optimal first-stage solution of $x^1 = 2$, which corresponds to production in the model, and $y^1 = 1$, which corresponds to stored_production.out in the model. Finally, they report an optimal value of 6.25.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Restructure the examples in the documentation
3 participants