Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Top bar menu on hover not reacting #12

Open
acorbi opened this issue Feb 1, 2015 · 5 comments
Open

Top bar menu on hover not reacting #12

acorbi opened this issue Feb 1, 2015 · 5 comments

Comments

@acorbi
Copy link

acorbi commented Feb 1, 2015

bildschirmfoto 2015-02-01 um 10 24 11
Tested using firefox 35.0.1 & chrome 40.0.2214.94 (64-bit)
When hovering on the top bar menu over the News or Maps sections, no content is shown. Expected behaviour is that the user can select among the posts of that category.

In case the reason is that there is no post from that category to display, then a message such as "No posts avaialble under this category" should be shown.

@Huyeng
Copy link

Huyeng commented Feb 1, 2015

I agree with Alex, should sow a message if no content available.
From my understanding, some news of ODC won't show because ODC's news has post types "news" or "post".

@acorbi
Copy link
Author

acorbi commented Feb 1, 2015

Then, IMHO, we should do one this 2 things:

  1. Bulk change the post types from "news" or "posts" to that type the theme expects.
  2. Change the theme logic so it presents also posts with types "news" or "posts".
    @miguelpeixe @Huyeng Which one would you favorise?

@miguelpeixe
Copy link
Contributor

On this theme news and posts are the same post type (post). The news title is just to give more meaning to it. I chose to use the default "post" post type because it already contemplates the concept of news on it's default behaviour, without the need of any extra setup.

Any "news" post type from the previous WordPress theme/setup should be migrated to the "post" post type. If you prefer to use "news" post type I can set it up on this theme.

About the menu, the idea is to not interact with non existing content. The menu that has content gets a different hover style (gray background color) to highlight between the 'static' menus. I can change it to show "no content found", but I think that this way is better.

@miguelpeixe
Copy link
Contributor

Any conclusions on this matter?

@acorbi
Copy link
Author

acorbi commented Mar 2, 2015

I believe now is working fine.

@Huyeng Are we happy how the menu is working now? Should we close this?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants