prov/rxm: fix rxm multi recv getopt segfault #10725
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@aingerson tagging you since this fix seems related to some of your previous patches. |
j-xiong
reviewed
Jan 27, 2025
prov/rxm/src/rxm_ep.c
Outdated
Comment on lines
272
to
276
| case FI_OPT_MIN_MULTI_RECV: | ||
| return rxm_ep->srx->ep_fid.ops->getopt(&rxm_ep->srx->ep_fid.fid, | ||
| level, optname, optval, optlen); | ||
| assert(sizeof(rxm_ep->min_multi_recv_size) == sizeof(size_t)); | ||
| *(size_t *)optval = rxm_ep->min_multi_recv_size; | ||
| *optlen = sizeof(size_t); | ||
| break; |
There was a problem hiding this comment.
Both situations need to be handled, for example:
if (rxm_ep->srx) {
/* the old code here */
} else {
/* the new code here */
}
this prevents a segfault when the application calls fi_getopt of FI_OPT_MIN_MULTI_RECV before the endpoint gets enabled. Signed-off-by: Jerome Soumagne <[email protected]>
j-xiong
approved these changes
Jan 30, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
this prevents a segfault when the application calls fi_getopt of FI_OPT_MIN_MULTI_RECV before the endpoint gets enabled.