Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Date type guessing is too aggressive on some inputs #140

Open
ThrawnCA opened this issue Aug 17, 2015 · 0 comments
Open

Date type guessing is too aggressive on some inputs #140

ThrawnCA opened this issue Aug 17, 2015 · 0 comments

Comments

@ThrawnCA
Copy link
Contributor

The date parser used by type_guess is very forgiving - so much so that it accepts even a single letter 'A'. Which our data uses as a status code.

This makes sense when the date library is being used as a generic parser, but not for type detection. Perhaps DateUtilType could have a 'test' function that automatically rejects any value with length 1.
ThrawnCA added a commit to ThrawnCA/messytables that referenced this issue Aug 17, 2015
@ThrawnCA
don't parse inputs with length 1 as dates okfn#140
ea7c40e
davidread pushed a commit that referenced this issue Nov 4, 2015
Merge pull request #141 from ThrawnCA/master
8df73fa 
Don't parse inputs with length 1 as dates #140
@pudo pudo mentioned this issue Jul 23, 2016
Closed
@davidread davidread mentioned this issue Apr 7, 2017
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@ThrawnCA