Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Boolean type parses values 0 and 1 backwards #154

Closed
dsagal opened this issue Jul 5, 2016 · 1 comment · May be fixed by #171
Closed

Boolean type parses values 0 and 1 backwards #154

dsagal opened this issue Jul 5, 2016 · 1 comment · May be fixed by #171

Comments

@dsagal
Copy link

dsagal commented Jul 5, 2016

This code https://github.com/okfn/messytables/blob/master/messytables/types.py#L117 considers "0" to be True, and "1" to be False. That seems the opposite of what it should do.

@StevenMaude
Copy link
Contributor

Thanks for reporting. This is a duplicate of #146; closing.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants