RateLimiting functionality does not work

[TriggerAu]

In the documentation it talks to how the powershell module handles rate limiting using two configuration attributes
https://github.com/okta/okta-powershell-cli?tab=readme-ov-file#rate-limiting

There is a code file to handle this behaviour, but it is never accessed in my testing: https://github.com/okta/okta-powershell-cli/blob/main/src/Okta.PowerShell/Client/OktaRetryApi.ps1

In the APIClient calls here:

okta-powershell-cli/src/Okta.PowerShell/Private/OktaApiClient.ps1

Lines 144 to 188 in f78b2c6

	if ($SkipCertificateCheck -eq $true) {
	if ($null -eq $Configuration["Proxy"]) {
	# skip certification check, no proxy
	$RawResponse = Invoke-WebRequest -Uri $UriBuilder.Uri `
	-Method $Method `
	-Headers $HeaderParameters `
	-Body $RequestBody `
	-ErrorAction Stop `
	-UseBasicParsing `
	-SkipCertificateCheck `
	-UserAgent $OktaUserAgent
	} else {
	# skip certification check, use proxy
	$RawResponse = Invoke-WebRequest -Uri $UriBuilder.Uri `
	-Method $Method `
	-Headers $HeaderParameters `
	-Body $RequestBody `
	-ErrorAction Stop `
	-UseBasicParsing `
	-SkipCertificateCheck `
	-Proxy $Configuration["Proxy"].GetProxy($UriBuilder.Uri) `
	-ProxyUseDefaultCredentials `
	-UserAgent $OktaUserAgent
	}
	} else {
	if ($null -eq $Configuration["Proxy"]) {
	# perform certification check, no proxy
	$RawResponse = Invoke-WebRequest -Uri $UriBuilder.Uri `
	-Method $Method `
	-Headers $HeaderParameters `
	-Body $RequestBody `
	-ErrorAction Stop `
	-UseBasicParsing `
	-UserAgent $OktaUserAgent
	} else {
	# perform certification check, use proxy
	$RawResponse = Invoke-WebRequest -Uri $UriBuilder.Uri `
	-Method $Method `
	-Headers $HeaderParameters `
	-Body $RequestBody `
	-ErrorAction Stop `
	-UseBasicParsing `
	-Proxy $Configuration["Proxy"].GetProxy($UriBuilder.Uri) `
	-ProxyUseDefaultCredentials `
	-UserAgent $OktaUserAgent

they are set with an ErrorAction of Stop and the IWR method also throws fatal errors based on the server response, so the code to retry or not is never reached.

In Powershell 7 - where I am working - there is a -SkipHTTPErrorCheck that can help handle this, but I haven't yet had the time to dig deeper on this one

[laura-rodriguez]

HI @TriggerAu,

Thanks for reporting this issue. I filed an internal ticket that the team will review and prioritize accordingly.

Internal Ref: OKTA-825260

[TriggerAu]

Fix is up in PR

[laura-rodriguez]

Thank you for your contribution @TriggerAu!

Can you please review and sign the Okta Individual Contributor License Agreement?

[TriggerAu]

Can you please review and sign the Okta Individual Contributor License Agreement?

Hey @laura-rodriguez I did give that a read a while back and chatted with my companies Okta Account Manager. As everything Ive PRed to date is in the Bug/"Obvious Fix" category - typos, datatypes, etc - it didn't seem to fit.

If there's something extra lets organise a chat with our account team