Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

AndroidX Jetpack migration needed #158

Open
anggrayudi opened this issue Dec 19, 2018 · 5 comments
Open

AndroidX Jetpack migration needed #158

anggrayudi opened this issue Dec 19, 2018 · 5 comments

Comments

@anggrayudi
Copy link

Well, I think we need to publish this library with AndroidX Jetpack ASAP. I checked so many dependencies on my project, and found that 3 of 19 dependencies are still using old Support Library. Material Range Bar is one of them. I am aware that this lib will cause crash to my app since Support Library has different package name with AndroidX Jetpack. We don't have to wait until stable version 1.0.0 is released by Google. We can do it now. I have tested AndroidX and found no problem with it.

@TurKurT656
Copy link

Yes it cause crashes with this lib

@mikekudzin
Copy link

mikekudzin commented Feb 24, 2019

@TurKurT656 have you tried enableJetifier flag?

@TurKurT656
Copy link

@TurKurT656 have you tried enableJetifier flag?

yes it was enabled.

@mikekudzin
Copy link

@anggrayudi @TurKurT656 Could you provide more info on the issue? Crash log, material-range-bar version, android gradle plugin/build tools version and so on
Particularly I use the library (1.4.5) along with androidx appcompat 1.0.2 and android gradle plugin 3.3.1 and default build tools version for this plugin.

android.enableJetifier=true
android.useAndroidX=true

are enabled too. I have tested our app on few android versions 18 to 28 and found no issues so far.
However, it is still vital for me know about any problems I could have missed before releasing the app to prod.
Could you confirm the library is crashing your apps even using the config provided by me?

@TurKurT656
Copy link

@anggrayudi @TurKurT656 Could you provide more info on the issue? Crash log, material-range-bar version, android gradle plugin/build tools version and so on
Particularly I use the library (1.4.5) along with androidx appcompat 1.0.2 and android gradle plugin 3.3.1 and default build tools version for this plugin.

android.enableJetifier=true
android.useAndroidX=true

are enabled too. I have tested our app on few android versions 18 to 28 and found no issues so far.
However, it is still vital for me know about any problems I could have missed before releasing the app to prod.
Could you confirm the library is crashing your apps even using the config provided by me?

Today I've tested the newer version (1.4.5) with androidX and there is no error.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants