Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Select Range doesn't handle big data properly #4523

Open
azmy60 opened this issue Jun 19, 2024 · 3 comments · May be fixed by #4675
Open

Select Range doesn't handle big data properly #4523

azmy60 opened this issue Jun 19, 2024 · 3 comments · May be fixed by #4675
Labels
Possible Bug A possible bug that needs investigation

Comments

@azmy60
Copy link
Collaborator

azmy60 commented Jun 19, 2024 •
edited
Loading

Right now, if I have a 8mb of dataset (5000 rows) on tabulator with Select Range enabled, it becomes very slow. Selecting a cell by clicking it takes about 5-10 seconds until it actually shows the selection outlines and the UI hangs within those seconds.

It looks like Select Range is looping through all data instead of the data that are necessary to check. It should work like virtual renderer.

I used the same dataset on google sheet and it works perfectly and doesn't lag at all except when I paste the data right onto it which takes around > 10 seconds.
@azmy60 azmy60 added the Possible Bug A possible bug that needs investigation label Jun 19, 2024
@olifolkerd
Copy link
Owner

@azmy60 as the man who built the select range module, are you not best placed to submit a PR for this one?

Cheers

Oli :)

@ackory
Copy link

ackory commented Jan 29, 2025

Hi @olifolkerd, I just started using this library (it's great btw) and I noticed this issue where selecting a range of cells lags quite a bit when I get anywhere above 15-20k rows (I've tested so far with about 10-20 columns and up to 100k rows where it really lags). This is one feature my users really utilize. It would be great if there is a fix for this.

Thanks for all your work on this! :)

@azmy60
Copy link
Collaborator Author

azmy60 commented Jan 29, 2025

I can take a look at this around this week or next week in my free time. But feel free to look into this if anyone wishes to!

@azmy60 azmy60 linked a pull request Feb 2, 2025 that will close this issue
Draft
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Possible Bug A possible bug that needs investigation
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix slow range selection if the data is big olifolkerd/tabulator
3 participants
@olifolkerd @azmy60 @ackory