TPCC benchmark violates consistency conditions

[rnbguy]

Shouldn't all the executeBatch() be called out of these if-blocks?

oltpbench/src/com/oltpbenchmark/benchmarks/tpcc/TPCCLoader.java

Lines 200 to 205 in dc32a26

	if (batchSize == TPCCConfig.configCommitCount) {
	itemPrepStmt.executeBatch();
	itemPrepStmt.clearBatch();
	transCommit(conn);
	batchSize = 0;
	}

oltpbench/src/com/oltpbenchmark/benchmarks/tpcc/TPCCLoader.java

Lines 334 to 338 in dc32a26

	if ((k % TPCCConfig.configCommitCount) == 0) {
	stckPrepStmt.executeBatch();
	stckPrepStmt.clearBatch();
	transCommit(conn);
	}

oltpbench/src/com/oltpbenchmark/benchmarks/tpcc/TPCCLoader.java

Lines 509 to 515 in dc32a26

	if ((k % TPCCConfig.configCommitCount) == 0) {
	custPrepStmt.executeBatch();
	histPrepStmt.executeBatch();
	custPrepStmt.clearBatch();
	custPrepStmt.clearBatch();
	transCommit(conn);
	}

oltpbench/src/com/oltpbenchmark/benchmarks/tpcc/TPCCLoader.java

Lines 655 to 667 in dc32a26

	if ((k % TPCCConfig.configCommitCount) == 0) {
	ordrPrepStmt.executeBatch();
	if (newOrderBatch > 0) {
	nworPrepStmt.executeBatch();
	newOrderBatch = 0;
	}
	orlnPrepStmt.executeBatch();
	ordrPrepStmt.clearBatch();
	nworPrepStmt.clearBatch();
	orlnPrepStmt.clearBatch();
	transCommit(conn);
	}

Because when this commit() is called in the end, the prepared statements in the last turns, are never taken account.

oltpbench/src/com/oltpbenchmark/api/Loader.java

Line 64 in dc32a26

this.conn.commit();

.. and D_NEXT_O_ID is getting hardcoded here.

oltpbench/src/com/oltpbenchmark/benchmarks/tpcc/TPCCLoader.java

Line 374 in dc32a26

district.d_next_o_id = TPCCConfig.configCustPerDist + 1;

.. which, in turn, violates TPCC consistency conditions 2 and 3 after loading phase and execution phase respectively.