Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG] ERROR HANDLING IN load_dataset (line no. 22) #110

Open
PreetSharma-12 opened this issue Oct 19, 2024 · 2 comments
Open

[BUG] ERROR HANDLING IN load_dataset (line no. 22) #110

PreetSharma-12 opened this issue Oct 19, 2024 · 2 comments
Assignees
Labels
bug Something isn't working good first issue Good for newcomers gssoc-ext hacktoberfest-accepted

Comments

@PreetSharma-12
Copy link

PreetSharma-12 commented Oct 19, 2024

The exit(1) call is generally not advisable in libraries or modules. Instead of raising an exception, I would like to allow the calling function to handle it.
I think it would be more effective for the project.
I have fixed the issue and attached a screenshot of before and after of the code.
Please assign me this issue @ombhojane Sir

Before :
Screenshot numpy2

After :
Screenshot numpy2 correct

@PreetSharma-12 PreetSharma-12 added the bug Something isn't working label Oct 19, 2024
@ombhojane
Copy link
Owner

Sure, you can add custom raise error for this. @PreetSharma-12 go ahead

@PreetSharma-12
Copy link
Author

Thankyou Sir, I'm creating the PR in a few minutes.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working good first issue Good for newcomers gssoc-ext hacktoberfest-accepted
Projects
None yet
Development

No branches or pull requests

2 participants