Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve handling of network errors #99

Closed
dominikl opened this issue Dec 17, 2019 · 4 comments
Closed

Improve handling of network errors #99

dominikl opened this issue Dec 17, 2019 · 4 comments

Comments

@dominikl
Copy link
Member

dominikl commented Dec 17, 2019

Sometimes Insight crashes on network/connection issues, when it actually should be able to recover from them. When it's not possible to recover there should be at least a better error message for the user.

See for example 28982

@dominikl
Copy link
Member Author

Another example: https://www.openmicroscopy.org/qa2/qa/feedback/29290/ .
Unfortunately one can't replicate the problem by simply disconnecting and reconnecting the network. I have to try with a VM and netem at some point.

@dominikl
Copy link
Member Author

dominikl commented Jul 31, 2020

Adding more bug report here:

@dominikl
Copy link
Member Author

The reason why reconnecting sometimes work and sometimes doesn't is how the data from the server is requested. If it is through the OMEROGateway then it's fine, because exceptions are handled by

boolean handleConnectionException(Throwable e)
(which opens the connection issue dialog and tries to reconnect), whereas if the Java Gateway is used directly, then the exception isn't handled and Insight crashes. So probably all uses of the Java Gateway have to reviewed and wrapped into respective methods in the OMEROGateway which catches the Exceptions.

@dominikl
Copy link
Member Author

These cases have been dealt with. But it looks like there are more, created a new issue for them: #430

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant