Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

populate metadata: Allow no Parent column #25

Open
will-moore opened this issue Jul 9, 2019 · 0 comments
Open

populate metadata: Allow no Parent column #25

will-moore opened this issue Jul 9, 2019 · 0 comments
Labels
enhancement New feature or request

Comments

@will-moore
Copy link
Member

will-moore commented Jul 9, 2019

If I have an Image column with Image IDs, but I don't have any Parent column (E.g. Dataset Name or Dataset, currently the populate metadata script fails with:
'Unable to locate Parent column in Row: %r' % row simply because the script wants to check that the Image IDs are valid within a specified Dataset.
This seems too strict in many cases where I am already happy that the Image IDs are valid.

I would prefer that if no Parent column is found, we simply accept that the Image ID is valid.

Instead of

        if images_by_id is None:
            raise MetadataError(
                'Unable to locate Parent column in Row: %r' % row
            )

we simply do:

        if images_by_id is None:
            return long(value)
@sbesson sbesson added the enhancement New feature or request label Aug 1, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants