Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update the tests to NOT use .env and hardcode HOME_RPC_URL and FOREIGN_RPC_URL #90

Closed
pertsev opened this issue Jun 7, 2019 · 6 comments · Fixed by #93
Closed

Update the tests to NOT use .env and hardcode HOME_RPC_URL and FOREIGN_RPC_URL #90

pertsev opened this issue Jun 7, 2019 · 6 comments · Fixed by #93
Assignees
Labels
UI related to TokenBridge UI

Comments

@pertsev
Copy link

pertsev commented Jun 7, 2019

This couple of tests is constantly failing
https://github.com/poanetwork/token-bridge/blob/adb29317b070f620ee5749b54272f822b6446e3d/test/gasPrice.test.js#L116-L140

Environment:
node 10
yarn 1.16.0

image

@akolotov
Copy link
Collaborator

akolotov commented Jun 7, 2019

Please check on the monorepo. CircleCI reports about successful runs of all tests: tests on the latest master commit

@pertsev
Copy link
Author

pertsev commented Jun 7, 2019

@akolotov The same story on yarn test in monorepo

image

@rzadp
Copy link
Contributor

rzadp commented Jun 7, 2019

@pertsev Please try the following:

cd tokenbridge/oracle
mv .env .env.bak
echo -e "HOME_RPC_URL=http://example.com\nFOREIGN_RPC_URL=http://example.com\n" > .env
yarn test

@akolotov The issue is that the oracle tests require specific set of env vars. They're set up on CI following the setup I saw on .travis.yml:
Screenshot 2019-06-07 at 09 06 58

Apparently they fail if there is more vars (specifically HOME_GAS_PRICE_UPDATE_INTERVAL and FOREIGN_GAS_PRICE_UPDATE_INTERVAL), which are introduced when doing cp .env.example .env

So I figure that this issue should be renamed into either:

  • Update the documentation
  • or, Update the tests to NOT use .env and hardcode HOME_RPC_URL and FOREIGN_RPC_URL ?

@rzadp rzadp added the UI related to TokenBridge UI label Jun 7, 2019
@akolotov
Copy link
Collaborator

akolotov commented Jun 7, 2019

@rzadp thanks for the investigation. I would vote for the second approach.

are you going to address it or I could ask Gerardo (@patitonar)

@rzadp
Copy link
Contributor

rzadp commented Jun 7, 2019

I will try and fix it with the second approach.

@akolotov
Copy link
Collaborator

akolotov commented Jun 7, 2019

@rzadp thanks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
UI related to TokenBridge UI
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants