Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement store add in CLI #195

Open
Tracked by #205
alilleybrinker opened this issue Aug 23, 2024 · 0 comments
Open
Tracked by #205

Implement store add in CLI #195

alilleybrinker opened this issue Aug 23, 2024 · 0 comments
Labels
crate: omnibor-cli Relating to the omnibor-cli crate good first issue Good for newcomers type: feature New feature or request

Comments

@alilleybrinker
Copy link
Member

Right now, the CLI can only create new manifests directly in the store with the manifest create subcommand. We want it to also be able to add manifests which exist on the local file system but are not found in the manifest store.

The general process should look like:

  • Checking if a file is a valid manifest by parsing it and storing it in memory.
  • (If the user provided a target), modifying the in-memory manifest to include that target.
  • Writing the manifest to storage.

The advantage of making it in memory and writing it out this way is that it will use the same existing code that ensures we update the target index to record the target of the manifest.

@alilleybrinker alilleybrinker added type: feature New feature or request good first issue Good for newcomers crate: omnibor-cli Relating to the omnibor-cli crate labels Aug 23, 2024
@alilleybrinker alilleybrinker moved this to Backlog in OmniBOR Rust Aug 23, 2024
@alilleybrinker alilleybrinker changed the title Implement manifest add in CLI Implement store add in CLI Nov 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
crate: omnibor-cli Relating to the omnibor-cli crate good first issue Good for newcomers type: feature New feature or request
Projects
Status: Backlog
Development

No branches or pull requests

1 participant