Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

unify forks #1

Open
tkruse opened this issue Jan 2, 2015 · 3 comments
Open

unify forks #1

tkruse opened this issue Jan 2, 2015 · 3 comments

Comments

@tkruse
Copy link

tkruse commented Jan 2, 2015

Hello ondrej,

I had already put cpplint on github here:
https://github.com/tkruse/cpplint

I have not modified the code (I think), but I made it available on pypi:
https://pypi.python.org/pypi/cpplint
That way it is easy for people to install.

If you are interested, we could merge your modifications and my structure to put on pypi, and then if you like you could maintain on pypi (release 0.0.4 under your maintainer name).

@ondrasej
Copy link
Owner

ondrasej commented Jan 2, 2015

Hi Thibault,

I've made a few modifications, but I didn't pull any updates from the "official" repository at Google Code since 2011, which probably means that my version is too old to be useful.

I'll see if I can push my changes directly to the official version - it might take some time and I'm not sure they'll be accepted, but it's worth trying and it would save a some patching and merging.

Re maintaining the version on pypi - I've never maintained a project like this so I'm not sure how much work/responsibility that means. But if it takes just a couple of minutes per release, I might be able to do it.

Ondrej

@tkruse
Copy link
Author

tkruse commented Jan 2, 2015

hah, same as me, but it was only 3 commits since 2012. I also asked the last committer whether google cannot just mantain this on github, since by now I found at least 3 other forks. Putting stuff on Pypi is no big deal, but you need an account, password, etc. I have not done anything for this the last 2 years, so it's not that much responsibility, or I am not a responsible person :-)
Let's wait if the last commiter answers

@tkruse
Copy link
Author

tkruse commented Jan 4, 2015

In any case I updated my fork, and added a README.md with maintenance instructions. some git skills would be required.

Also I submitted most of my patches to the google styleguide issue tracker:
https://code.google.com/p/google-styleguide/issues/list
If you submit your changes there, maybe they'll get accepted. However I think they added a feature similar to the one you added.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants