Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove CONTEXT_INFO_ATOMIC_ queries. #2119

Open
aarongreig opened this issue Sep 23, 2024 · 0 comments
Open

Remove CONTEXT_INFO_ATOMIC_ queries. #2119

aarongreig opened this issue Sep 23, 2024 · 0 comments
Labels
specification Changes or additions to the specification
Milestone

Comments

@aarongreig
Copy link
Contributor

Looking at https://github.com/oneapi-src/unified-runtime/pull/2112/files I noticed that none of the adapters implement the CONTEXT_INFO_ATOMIC_ queries. I found the PR that introduced the PI queries and it seems they were always intended as a meta-query for sycl runtime to implement rather than something for the plugins to implement separately. The implementations all look something like this with an intersection being found between the capabilities of each device in the context. We have a better way of handling sycl runtime only queries now, the __SYCL_TRAIT_HANDLED_IN_RT macro, so I think there's a strong argument to be made for deleting these queries from UR and using the macro in the SYCL rt instead.

@aarongreig aarongreig added the specification Changes or additions to the specification label Sep 23, 2024
@aarongreig aarongreig added this to the Backlog milestone Sep 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
specification Changes or additions to the specification
Projects
None yet
Development

No branches or pull requests

1 participant