You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Looking at https://github.com/oneapi-src/unified-runtime/pull/2112/files I noticed that none of the adapters implement the CONTEXT_INFO_ATOMIC_ queries. I found the PR that introduced the PI queries and it seems they were always intended as a meta-query for sycl runtime to implement rather than something for the plugins to implement separately. The implementations all look something like this with an intersection being found between the capabilities of each device in the context. We have a better way of handling sycl runtime only queries now, the __SYCL_TRAIT_HANDLED_IN_RT macro, so I think there's a strong argument to be made for deleting these queries from UR and using the macro in the SYCL rt instead.
The text was updated successfully, but these errors were encountered:
Looking at https://github.com/oneapi-src/unified-runtime/pull/2112/files I noticed that none of the adapters implement the CONTEXT_INFO_ATOMIC_ queries. I found the PR that introduced the PI queries and it seems they were always intended as a meta-query for sycl runtime to implement rather than something for the plugins to implement separately. The implementations all look something like this with an intersection being found between the capabilities of each device in the context. We have a better way of handling sycl runtime only queries now, the __SYCL_TRAIT_HANDLED_IN_RT macro, so I think there's a strong argument to be made for deleting these queries from UR and using the macro in the SYCL rt instead.
The text was updated successfully, but these errors were encountered: