Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add variants of UUR_KNOWN_FAILURE_ON to perform xfail and/or negative device matching #2548

Open
RossBrunton opened this issue Jan 10, 2025 · 0 comments

Comments

@RossBrunton
Copy link
Contributor

Currently UUR_KNOWN_FAILURE_ON accepts a list of device specifiers and skips the tests if any match. It would be nice to extend this logic to:

  • Mark the test as xfail (if such a thing exists in gtest), so that developers writing a patch would be notified of tests that they need to re-enable. Note that converting UUR_KNOWN_FAILURE_ON directly to use xfails will not work, as some tests segfault which would bring the whole test suite down.
  • Use a negative match; "this test fails on every device except the ones matched by this specifier". Will be useful for testing features that are currently in development and do not work on every device yet.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant