From 3877f8f16ae59979962a0f501bd2d251523f1acf Mon Sep 17 00:00:00 2001 From: markuczy Date: Tue, 25 Jun 2024 14:13:35 +0200 Subject: [PATCH 1/2] fix: paginator appended to body --- .../lib/components/data-list-grid/data-list-grid.component.html | 1 + .../src/lib/components/data-table/data-table.component.html | 1 + 2 files changed, 2 insertions(+) diff --git a/libs/angular-accelerator/src/lib/components/data-list-grid/data-list-grid.component.html b/libs/angular-accelerator/src/lib/components/data-list-grid/data-list-grid.component.html index a0922f2a..a6789c2c 100644 --- a/libs/angular-accelerator/src/lib/components/data-list-grid/data-list-grid.component.html +++ b/libs/angular-accelerator/src/lib/components/data-list-grid/data-list-grid.component.html @@ -9,6 +9,7 @@ currentPageReportTemplate="{{ (totalRecordsOnServer ? currentPageShowingWithTotalOnServerKey : currentPageShowingKey) | translate:params }}" [rowsPerPageOptions]="[10, 25, 50, data?.length]" id="dataListGrid_{{name}}" + paginatorDropdownAppendTo="body" > {{ item.value === data?.length ? ("OCX_DATA_TABLE.ALL" | translate) : item.value }} diff --git a/libs/angular-accelerator/src/lib/components/data-table/data-table.component.html b/libs/angular-accelerator/src/lib/components/data-table/data-table.component.html index d9d7236e..bf282994 100644 --- a/libs/angular-accelerator/src/lib/components/data-table/data-table.component.html +++ b/libs/angular-accelerator/src/lib/components/data-table/data-table.component.html @@ -94,6 +94,7 @@ (selectionChange)="onSelectionChange($event)" [selection]="(selectedRows$ | async) || []" [scrollable]="true" + paginatorDropdownAppendTo="body" > From 36f3ea2ebd2516a67df5d7532d4de8be7c3e484b Mon Sep 17 00:00:00 2001 From: markuczy Date: Tue, 25 Jun 2024 14:56:58 +0200 Subject: [PATCH 2/2] fix: harness fix --- .../src/lib/harnesses/primeng/p-dropdown.harness.ts | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/libs/angular-testing/src/lib/harnesses/primeng/p-dropdown.harness.ts b/libs/angular-testing/src/lib/harnesses/primeng/p-dropdown.harness.ts index 0dc82ae0..8b83a968 100644 --- a/libs/angular-testing/src/lib/harnesses/primeng/p-dropdown.harness.ts +++ b/libs/angular-testing/src/lib/harnesses/primeng/p-dropdown.harness.ts @@ -44,8 +44,9 @@ export class PDropdownHarness extends ContentContainerComponentHarness { async getDropdownItems() { await this.open() - const dropdownItems = this.locatorForAll(ListItemHarness)() - return await dropdownItems + const rootLocator = this.documentRootLocatorFactory() + const items = await rootLocator.harnessLoaderFor('.p-dropdown-items') + return await items.getAllHarnesses(ListItemHarness) } async getDropdownItem(itemText: string): Promise {