Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Security: the local path shouldn't appear in generated docs #72

Open
warpdesign opened this issue Feb 28, 2019 · 3 comments
Open

Security: the local path shouldn't appear in generated docs #72

warpdesign opened this issue Feb 28, 2019 · 3 comments
Labels
revision security

Comments

@warpdesign
Copy link
Contributor

warpdesign commented Feb 28, 2019 •
edited by onury
Loading

It seems that for some reason Docma adds the full local's path to the code it parses:

docma-issue-72-2

This path:

  • can be a security problem
  • has no use in this context
  • it makes the json generated un-necessary big
@onury
Copy link
Owner

onury commented Feb 28, 2019

That's by JSDoc itself but Docma should parse them out. You're right.

@warpdesign
Copy link
Contributor Author

warpdesign commented Feb 28, 2019 •
edited
Loading

@onury I saw you have hidden the local path from the screenshot: sorry for not doing it in the first place 😕

@onury
Copy link
Owner

onury commented Feb 28, 2019

No worries. Your feedback is valuable anyways.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
revision security
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@warpdesign @onury