Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Character image resolution loss on loading character. #6502

Open
1 task done
dEATh-PM opened this issue Oct 29, 2024 · 0 comments
Open
1 task done

Character image resolution loss on loading character. #6502

dEATh-PM opened this issue Oct 29, 2024 · 0 comments
Labels
bug Something isn't working

Comments

@dEATh-PM
Copy link

Describe the bug

When a character is loaded and a PFP is generated in chat.py > generate_pfp_cache a thumbnail is generated as well.
This thumbnail image is then returned back to state['character_picture'] for us in Gradio.
When saving the character, state['character_picture'] is saved as the image parallel to the character .yaml, overwriting the original, and potentialy larger, image.

If this was the intended behavior, I would have assumed the down scaling would be performed when an image is initially imported.

Suggested sollution:

            return original_img

Is there an existing issue for this?

  • I have searched the existing issues

Reproduction

  1. Import a character with an image larger than 350x470
  2. Save character by pressing 💾

alt.

  1. Create a character with an image larger than 350x470
  2. Load character
  3. Save character by pressing 💾

Screenshot

No response

Logs

N/A

System Info

N/A
@dEATh-PM dEATh-PM added the bug Something isn't working label Oct 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant