Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Doc] vLLM - typo in README.md #1249

Open
2 of 7 tasks
edlee123 opened this issue Jan 31, 2025 · 1 comment
Open
2 of 7 tasks

[Doc] vLLM - typo in README.md #1249

edlee123 opened this issue Jan 31, 2025 · 1 comment
Assignees
Labels
bug Something isn't working

Comments

@edlee123
Copy link

edlee123 commented Jan 31, 2025

Priority

P4-Low

OS type

Ubuntu

Hardware type

Xeon-GNR

Installation method

  • Pull docker images from hub.docker.com
  • Build docker images from source
  • Other

Deploy method

  • Docker
  • Docker Compose
  • Kubernetes Helm Charts
  • Other

Running nodes

Single Node

What's the version?

NA

Description

Small typos in comps/third_parties/vllm/README.md. Can change:

  • cd deplopyment/docker_compose to cd deployment/docker_compose two times.

  • docker compose -f compose.yaml vllm-gaudi-server up -d to docker compose -f compose.yaml up vllm-gaudi-server -d

And:

  • Should we make a script parameter: VLLM_CPU_KVCACHE_SPACE=40 (line 43)? Can make it a little easier to change cache size depending on machine's memory.

Reproduce steps

Documentation only.

Raw log

Attachments

No response

@edlee123 edlee123 added the bug Something isn't working label Jan 31, 2025
@edlee123 edlee123 changed the title [Bug] vLLM - typo in README.md [Doc] vLLM - typo in README.md Jan 31, 2025
@xiguiw xiguiw self-assigned this Feb 5, 2025
@xiguiw
Copy link
Collaborator

xiguiw commented Feb 5, 2025

@edlee123
Thanks for catching this typo.

Let me fix it, maybe some days later as there are lots of issues during the Chinese New Year after 1.2 release.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants