Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

check_data_quality: reinstate check on item classification schemes #24

Open
duncandewhurst opened this issue Aug 12, 2021 · 4 comments
Open

Comments

@duncandewhurst
Copy link
Contributor

This isn't covered in Pelican

@jpmckinney
Copy link
Member

@yolile Do you have any memory of this check?

@yolile
Copy link
Member

yolile commented Jul 5, 2023

Not really, but I suppose it is around checking whether a scheme exists and if it is valid. I'm not sure if this also included checking if the value item/classification/id is indeed part of the declared schema.

@jpmckinney
Copy link
Member

Aha, so that would fit under the "Ground truth" heading I added to group some existing checks.

@jpmckinney
Copy link
Member

jpmckinney commented Aug 15, 2023

I think this notebook contains the cells to be reinstated (basically, it unions the item classification schemes across tender, award and contract).

I don't think we can realistically "ground truth" classification IDs, as there can be thousands. But, we can at least check the schemes. (We can maybe add a query to produce a small sample of IDs to check.)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants