Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Why does Rhs2116StimulusTrigger take "double" instead of "bool"? #390

Open
cjsha opened this issue Dec 18, 2024 · 2 comments
Open

Why does Rhs2116StimulusTrigger take "double" instead of "bool"? #390

cjsha opened this issue Dec 18, 2024 · 2 comments
Milestone

Comments

@cjsha
Copy link
Member

cjsha commented Dec 18, 2024

I'm wondering why Rhs2116StimulusTrigger takes "double" instead of "bool" as the type of its input observable.

For reference, Headstage64ElectricalStimulatorTrigger and Headstage64OpticalStimulatorTrigger do take "bool" as their input observable type. I prefer how the hs64 does it because the graph for triggering in the example workflow can be more simple.

@jonnew
Copy link
Member

jonnew commented Jan 6, 2025

The trigger provided to an Rhs2116StimulusTrigger defines a delay in microseconds that will be applied prior to the defined stumulus.

device.WriteRegister(Rhs2116Trigger.TRIGGER, (uint)(delaySamples << 12 | 0x1));

This needs to be documented properly:

  1. Explain the difference between per channel Delay property and this global sequence delay.
  2. Update the RHS2116Trigger TRIGGER description with this information

image

@cjsha
Copy link
Member Author

cjsha commented Jan 6, 2025

My follow-up question is: should hs64 trigger operators follow the same pattern? They have a delay property instead of taking in delay in their input sequences

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants