Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FinalizeLink Action that runs when Acquisition stops or fails #47

Closed
jonnew opened this issue Jan 26, 2024 · 1 comment · Fixed by #63
Closed

FinalizeLink Action that runs when Acquisition stops or fails #47

jonnew opened this issue Jan 26, 2024 · 1 comment · Fixed by #63
Labels
feature New planned feature help wanted Extra attention is needed
Milestone

Comments

@jonnew
Copy link
Member

jonnew commented Jan 26, 2024

I think it would be beneficial to have a Finally() operator that turns the port voltage off when acquisition stops. My understanding is that all Actions and Functions gathered by Configure<thing>.cs nodes are executed by context.Configure() at line 23 of StartAcquisition:

https://github.com/neurogears/onix-refactor/blob/69c0d3546fb9eae5565a370fb7cfe9b182c06475/OpenEphys.Onix/OpenEphys.Onix/StartAcquisition.cs#L23

I think this sequence would need to have a Finally() appended to it, and Configure<thing>.cs nodes should have the ability to register a FinalizeLink Action that is executed in the Finally() operator appended to the StartAcqusition's observable sequence.

Originally posted by @jonnew in #46 (comment)

@jonnew
Copy link
Member Author

jonnew commented Feb 19, 2024

@glopesdev I remember that this may have been implemented in a branch, but I can't seem to find it. Let me know if I'm mistaken

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature New planned feature help wanted Extra attention is needed
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants