Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Change functional tests library #354

Closed
askpt opened this issue Jan 31, 2025 · 0 comments · Fixed by #368 · May be fixed by #372
Closed

Change functional tests library #354

askpt opened this issue Jan 31, 2025 · 0 comments · Fixed by #368 · May be fixed by #372
Assignees
@askpt
Labels
dependencies Updating a dependency good first issue Good for newcomers tests Improvement or additions to test suite

Comments

@askpt
Copy link
Member

askpt commented Jan 31, 2025

Description

The SpecFlow library was deprecated on December 31st, 2024. We should transition to another library currently actively supported for our functional tests suite. We are currently blocked from upgrading xUnit since SpecFlow depends on xUnit version 2.
One of the possibilities is Reqnroll.

More information
@askpt askpt added dependencies Updating a dependency good first issue Good for newcomers tests Improvement or additions to test suite labels Jan 31, 2025
@askpt askpt self-assigned this Feb 5, 2025
@askpt askpt mentioned this issue Feb 5, 2025
Merged
@askpt askpt linked a pull request Feb 5, 2025 that will close this issue
chore: Replace SpecFlow with Reqnroll for testing framework #368
Merged
github-merge-queue bot pushed a commit that referenced this issue Feb 11, 2025
@askpt
chore: Replace SpecFlow with Reqnroll for testing framework (#368)
ed6ee2c 
<!-- Please use this template for your pull request. -->
<!-- Please use the sections that you need and delete other sections -->

## This PR
<!-- add the description of the PR here -->
This pull request includes updates to the testing framework by replacing
SpecFlow with Reqnroll across multiple files.

Testing framework updates:

*
[`Directory.Packages.props`](diffhunk://#diff-5baf5f9e448ad54ab25a091adee0da05d4d228481c9200518fcb1b53a65d4156L29-R29):
Replaced SpecFlow packages with Reqnroll.xUnit package.
*
[`test/OpenFeature.E2ETests/OpenFeature.E2ETests.csproj`](diffhunk://#diff-ab2ad60395e1cc72b327459243ed8c5711efbd88531a3b3b813fb6c4c6019886L19-R19):
Updated package references to use Reqnroll.xUnit instead of SpecFlow
packages.
*
[`test/OpenFeature.E2ETests/Steps/EvaluationStepDefinitions.cs`](diffhunk://#diff-9ca6e89533e4b3f7a2deaf8de6d6f07a80b7eab2afa6f2e8bfc682b9ca60dc6bL7-R7):
Replaced `TechTalk.SpecFlow` with `Reqnroll` in the using directives.

### Related Issues
<!-- add here the GitHub issue that this PR resolves if applicable -->

Fixes #354

Signed-off-by: André Silva <[email protected]>
@openfeaturebot openfeaturebot mentioned this issue Feb 11, 2025
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@askpt askpt

Labels
dependencies Updating a dependency good first issue Good for newcomers tests Improvement or additions to test suite
Projects
None yet
Milestone
No milestone
1 participant
@askpt