Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add assertions for statically configured attributes #160

Open
toddbaert opened this issue Dec 4, 2024 · 0 comments
Open

Add assertions for statically configured attributes #160

toddbaert opened this issue Dec 4, 2024 · 0 comments
Labels
help wanted Extra attention is needed

Comments

@toddbaert
Copy link
Member

toddbaert commented Dec 4, 2024

With open-feature/flagd#1448, we can now inject arbitrary key/values into the evaluation. These are injected into flagd's evaluation in rpc mode, and delivered over the GetSyncMetadata call in in-process mode (and subsequently added to the provider's local evaluation).

We should add a -X arg here that adds some property, and then write a flag that makes use of that property in a rule, and lastly add an assertion about this flag in a test suite (probably flagd-json-evaluator.feature). This will ensure that the flag evaluates consistently when evaluated in all modes.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
help wanted Extra attention is needed
Projects
None yet
Development

No branches or pull requests

1 participant