Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Provide a client endpoint to trigger flag changes from outside the container, rather than trigger them periodically #190

Open
aepfli opened this issue Jan 16, 2025 · 3 comments
Labels
good first issue Good for newcomers help wanted Extra attention is needed

Comments

@aepfli
Copy link
Member

aepfli commented Jan 16, 2025

Currently, our testbed is changing a flag regularly to mimic flag changes and flag change events.
This works great, but it has the side effect that we regularly receive change events, which can lead to wrong results within the tests.
e.g. for the "InProcess," we currently have a bug where we are not moving from error to ready as long as there is no flag change event. So the e2e tests work due to the script.

Ideally, we would add a server with an endpoint where we can trigger this behaviour.

@aepfli aepfli added good first issue Good for newcomers help wanted Extra attention is needed labels Jan 16, 2025
@aepfli
Copy link
Member Author

aepfli commented Jan 16, 2025

i suggest to implement a HTTP server without bigger features (no ssl, no auth), i would suggest in go, which manipulates the flag configuration locally

@toddbaert
Copy link
Member

If we're doing this, could we also have the server restart flagd itself so we can control the unstable tests this way?

@aepfli
Copy link
Member Author

aepfli commented Jan 16, 2025

Sounds like a good idea, but I would start small and add this as a future improvement

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Good for newcomers help wanted Extra attention is needed
Projects
None yet
Development

No branches or pull requests

2 participants