From 375c20569d12ea8b2a2ad15d9a360cefbbf92ba3 Mon Sep 17 00:00:00 2001 From: Pradeep Date: Wed, 11 Sep 2024 11:11:09 +0200 Subject: [PATCH] doc updates and added test coverage Signed-off-by: Pradeep --- providers/flagd/README.md | 1 + .../contrib/providers/flagd/FlagdOptionsTest.java | 12 ++++++++++++ 2 files changed, 13 insertions(+) diff --git a/providers/flagd/README.md b/providers/flagd/README.md index 158538f1f..6095e022c 100644 --- a/providers/flagd/README.md +++ b/providers/flagd/README.md @@ -112,6 +112,7 @@ Given below are the supported configurations: | maxEventStreamRetries | FLAGD_MAX_EVENT_STREAM_RETRIES | int | 5 | rpc | | retryBackoffMs | FLAGD_RETRY_BACKOFF_MS | int | 1000 | rpc | | offlineFlagSourcePath | FLAGD_OFFLINE_FLAG_SOURCE_PATH | String | null | in-process | +| authority | FLAGD_AUTHORITY_OVERRIDE | String | null | rpc & in-process | > [!NOTE] > Some configurations are only applicable for RPC resolver. diff --git a/providers/flagd/src/test/java/dev/openfeature/contrib/providers/flagd/FlagdOptionsTest.java b/providers/flagd/src/test/java/dev/openfeature/contrib/providers/flagd/FlagdOptionsTest.java index 081193c22..793081f6c 100644 --- a/providers/flagd/src/test/java/dev/openfeature/contrib/providers/flagd/FlagdOptionsTest.java +++ b/providers/flagd/src/test/java/dev/openfeature/contrib/providers/flagd/FlagdOptionsTest.java @@ -34,6 +34,7 @@ void TestDefaults() { assertNull(builder.getOfflineFlagSourcePath()); assertEquals(Resolver.RPC, builder.getResolverType()); assertEquals(0, builder.getKeepAlive()); + assertNull(builder.getAuthority()); } @Test @@ -55,6 +56,7 @@ void TestBuilderOptions() { .customConnector(connector) .resolverType(Resolver.IN_PROCESS) .keepAlive(1000) + .authority("test.service") .build(); assertEquals("https://hosted-flagd", flagdOptions.getHost()); @@ -70,6 +72,7 @@ void TestBuilderOptions() { assertEquals(connector, flagdOptions.getCustomConnector()); assertEquals(Resolver.IN_PROCESS, flagdOptions.getResolverType()); assertEquals(1000, flagdOptions.getKeepAlive()); + assertEquals("test.service", flagdOptions.getAuthority()); } @@ -187,4 +190,13 @@ void testRpcProviderFromEnv_portConfigured_usesConfiguredPort() { assertThat(flagdOptions.getPort()).isEqualTo(1534); } + + + @Test + @SetEnvironmentVariable(key = AUTHORITY_OVERRIDE, value = "test.service") + void testAuthorityOverrideFromEnv() { + FlagdOptions flagdOptions = FlagdOptions.builder().build(); + + assertThat(flagdOptions.getAuthority()).isEqualTo("test.service"); + } }