Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add redoc to documentation #1003

Open
wants to merge 3 commits into
base: main
Choose a base branch
from
Open

Conversation

lukas-reining
Copy link
Member

@lukas-reining lukas-reining commented Feb 22, 2025

This PR

Adds OpenAPI docs for OFREP to the docs section.

I chose between https://github.com/rohit-gohri/redocusaurus and https://github.com/PaloAltoNetworks/docusaurus-openapi-docs.
In the end I chose the first, because docusaurus-openapi-docs expects to generate it's own sidebar which is really hard to merge with our sidebar, without giving up the auto-generation of our sidebar.

Please leave feedback if this is enough or if we want some more prose.

Fixes: #452

Also we need a mechanism to update the submodule when we do changes in the protocol repo. @toddbaert @beeme1mr how can we do it best? Like with the SDK docs?

Copy link

netlify bot commented Feb 22, 2025

Deploy Preview for openfeature ready!

Name Link
🔨 Latest commit 207c2a9
🔍 Latest deploy log https://app.netlify.com/sites/openfeature/deploys/67bb298d7c9a6a0008cb3ad4
😎 Deploy Preview https://deploy-preview-1003--openfeature.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@beeme1mr
Copy link
Member

Also we need a mechanism to update the submodule when we do changes in the protocol repo.

Renovate will update submodules automatically.

@lukas-reining
Copy link
Member Author

@beeme1mr sounds good!
I had to fix the submodules, missed to push the submodule itself.

@lukas-reining
Copy link
Member Author

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[DOC] add swagger live-docs for OFREP
2 participants