Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add evaluation details to finally hook stage #57

Open
beeme1mr opened this issue Feb 24, 2025 · 0 comments
Open

Add evaluation details to finally hook stage #57

beeme1mr opened this issue Feb 24, 2025 · 0 comments
Labels
good first issue Good for newcomers help wanted Extra attention is needed

Comments

@beeme1mr
Copy link
Member

Add evaluation details to finally hook stage.

Notes

This breaks the signature of the finally stages based on this spec enhancement. It is not considered a breaking change to the SDK because hooks are marked as experimental in the spec, and the change has no impact on known hooks.

- finally(hookContext, hookHints)
+finally(hookContext, evaluationDetails, hookHints)

Acceptance criteria:

  • finally hook stage modified
  • associated tests

Follow ups:

  • update contribs
@beeme1mr beeme1mr added good first issue Good for newcomers help wanted Extra attention is needed labels Feb 24, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
good first issue Good for newcomers help wanted Extra attention is needed
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@beeme1mr