-
Notifications
You must be signed in to change notification settings - Fork 26
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Upgrading to setuptools >= 58 breaks the build #632
Comments
sergei-maertens
added a commit
that referenced
this issue
Sep 6, 2021
sergei-maertens
added a commit
that referenced
this issue
Sep 6, 2021
You might want to switch to demjson3 in case you really only want to support Python 3 anymore. |
Thanks for the comment - but we don't use demjson, we just found that repository when investigating the setuptools issue and it was a good hint to figure out what was going wrong! |
Fixed via 3e9a8ea, django-yubin dropped pyzmail36 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
See also dmeranda/demjson#40 and https://setuptools.readthedocs.io/en/latest/history.html#v58-0-0
django-yubin depends on pyzmail36, which is a fork of pyzmail that does install on python 3.6+ (supposedly).
This relies on the
use_2to3
keyword (https://github.com/ascoderu/pyzmail/blob/master/pyzmail/setup.py#L104) to convert the Python 2 code to Python 3 at package installation time ( 🤯 ).Setuptools 58 removed this parameter, so now we get Python 2 code in our build which breaks things.
For the time being, I'm pinning setuptools to < 58.0 in CI etc. and keeping track of the issue here.
The text was updated successfully, but these errors were encountered: